fix(assets-controller): heal native token assetsInfo entries by Prithpal-Sooriya · Pull Request #9099 · MetaMask/core

Prithpal-Sooriya · 2026-06-11T19:33:06Z

Explanation

This commit introduces a new test case to ensure that the middleware correctly refetches asset metadata when the stored type is stale, even if an image is present. The test verifies that a previously misclassified native asset is updated to its correct type, enhancing the robustness of the asset handling logic.

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Localized metadata correction on merge using existing type resolution; only touches assets in the incoming update and is covered by new tests.

Overview
AssetsController now self-heals stale assetsInfo.type values when applying pipeline updates. After merging incoming metadata, it walks asset IDs present in the current assetsInfo or assetsBalance payload, compares each entry’s type to #getAssetType(assetId), and rewrites mismatches (e.g. zero-address “native” tokens still labeled erc20 from older persisted state).

Healing runs on handleAssetsUpdate / #updateState paths, so a balance-only or metadata refresh can fix types without a separate migration. Genuine ERC-20s are left unchanged; normalization still applies so non-checksummed keys in responses reconcile against the canonical ID.

The changelog records the fix under Unreleased; tests cover native→erc20 healing via assetsInfo and assetsBalance, no-op for real ERC-20s, and checksum vs lowercase asset IDs.

^{Reviewed by Cursor Bugbot for commit 249ad86. Bugbot is set up for automated code reviews on this repo. Configure here.}

… metadata This commit introduces a new test case to ensure that the middleware correctly refetches asset metadata when the stored type is stale, even if an image is present. The test verifies that a previously misclassified native asset is updated to its correct type, enhancing the robustness of the asset handling logic.

Prithpal-Sooriya · 2026-06-11T22:40:19Z

@cursor READ AND FOLLOW THESE MEMORY FILES:

https://raw.githubusercontent.com/Prithpal-Sooriya/Cloud-Agent-Memory/refs/heads/main/Memory.md

/babysit fix CI

cursor · 2026-06-11T22:40:32Z

Taking a look!

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 7480667. Configure here.}

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

Prithpal-Sooriya · 2026-06-11T23:18:46Z

+        const assetsInfoAssetIdsSet = new Set(
+          Object.keys(normalizedResponse.assetsInfo ?? {}) as Caip19AssetId[],
+        );


@cursor I had a good back and forth with Claude around this.
The reason this works is because RPC detection can pick this up and therefore have some assetsInfo to rely on.

So as a safe measure we can use both the assetsInfo and assetsBalance.

const assetsInfoAssetIdsSet = new Set([ ...Object.keys(normalizedResponse.assetsInfo ?? {}), ...Object.entries(normalizedResponse.assetsBalance ?? {}).flatMap( ([_, b]) => Object.keys(b), ), ] as Caip19AssetId[]);

Thoughts?

Good call — I agree with your proposal, and I’ve already applied it.

Thoughts

Using both normalized assetsInfo and normalized assetsBalance keys is the safer behavior:

It preserves the assetsInfo-first logic.

It also heals stale types when a response only touches balance (which can happen via RPC detection flows).

Because both come from normalizedResponse, it avoids the non-checksummed key mismatch bug.

What I changed

Implemented reconciliation key set as union of:

Object.keys(normalizedResponse.assetsInfo ?? {})

asset IDs found in normalizedResponse.assetsBalance entries

Then reconciles metadata[assetId].type for all those touched IDs.

Added coverage

New test:
reconciles a stale native type stored as erc20 when assetsBalance includes the asset

Existing normalized-key reconciliation test remains in place.

Changelog

Updated to reflect behavior now applies when asset appears in incoming:

assetsInfo or assetsBalance.

Validation run

Passed locally:

yarn lint:misc:check

yarn eslint packages/assets-controller/src/AssetsController.ts packages/assets-controller/src/AssetsController.test.ts

yarn workspace @metamask/assets-controller run jest --no-coverage src/AssetsController.test.ts --runInBand --forceExit

yarn changelog:validate

Git

Commit: 0eef15d37

Pushed to fix/heal-native-token-entries

PR fix(assets-controller): heal native token assetsInfo entries #9099 updated

Fresh CI run is in progress for this commit.

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

…healing metadata cp-13.35.0 (#43477) ## **Description** Patch for this core fix: MetaMask/core#9099 ## **Changelog**  CHANGELOG entry: fix(assets-controller): update patch to add reconciliation/self-healing metadata ## **Related issues** Fixes: #43352 ## **Manual testing steps** 1. Start application on 13.34.0. Add IMX chain and token. 2. Inspect state - `AssetsController.assetsInfo["eip155:13371/erc20:0x0000000000000000000000000000000000000000"]` - See that the token is marked as "erc20" 3. Start application with these changes 4. Inspect state - `AssetsController.assetsInfo["eip155:13371/erc20:0x0000000000000000000000000000000000000000"]` - See that the token is marked as "native" ## **Screenshots/Recordings**  ### **Before** ```json { "aggregators": [], "decimals": 18, "erc20Permit": false, "image": "https://static.cx.metamask.io/api/v2/tokenIcons/assets/eip155/13371/erc20/0x0000000000000000000000000000000000000000.png", "name": "Immutable X", "occurrences": 100, "symbol": "IMX", "type": "erc20" } ``` ### **After** ``` { "aggregators": [], "decimals": 18, "erc20Permit": false, "image": "https://static.cx.metamask.io/api/v2/tokenIcons/assets/eip155/13371/erc20/0x0000000000000000000000000000000000000000.png", "name": "Immutable X", "occurrences": 100, "symbol": "IMX", "type": "native" } ``` https://www.loom.com/share/45f25216181146a69fc4730786c8fec9 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.  --- > [!NOTE] > **Medium Risk** > Changes how persisted asset metadata types are updated across websocket/RPC flows; incorrect classification could affect portfolio display until the next reconcile, but the logic is narrowly corrective. > > **Overview** > Updates the **Yarn patch** for `@metamask/assets-controller@8.3.2` to backport MetaMask/core#9099: asset metadata **types** are reconciled when balance/info updates land, so mislabeled entries (e.g. IMX native at the zero address stored as `erc20`) are corrected to `native`, `spl`, or `erc20`. > > The patch adds a **`getAssetType`** helper on `AssetsController` and passes it into **BackendWebsocket**, **RPC**, and **price** data sources (replacing the websocket’s `isNativeAsset` hook). During `_updateState`, it walks asset IDs from incoming `assetsInfo` / `assetsBalance` and **self-heals** `metadata[assetId].type` when it disagrees with `getAssetType`, marking those IDs as changed metadata. > > `yarn.lock` is refreshed for the new patch hash/checksum only. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 13e0626. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

…add reconciliation/self-healing metadata cp-13.35.0 (#43477) ## **Description** Patch for this core fix: MetaMask/core#9099 ## **Changelog**  CHANGELOG entry: fix(assets-controller): update patch to add reconciliation/self-healing metadata ## **Related issues** Fixes: #43352 ## **Manual testing steps** 1. Start application on 13.34.0. Add IMX chain and token. 2. Inspect state - `AssetsController.assetsInfo["eip155:13371/erc20:0x0000000000000000000000000000000000000000"]` - See that the token is marked as "erc20" 3. Start application with these changes 4. Inspect state - `AssetsController.assetsInfo["eip155:13371/erc20:0x0000000000000000000000000000000000000000"]` - See that the token is marked as "native" ## **Screenshots/Recordings**  ### **Before** ```json { "aggregators": [], "decimals": 18, "erc20Permit": false, "image": "https://static.cx.metamask.io/api/v2/tokenIcons/assets/eip155/13371/erc20/0x0000000000000000000000000000000000000000.png", "name": "Immutable X", "occurrences": 100, "symbol": "IMX", "type": "erc20" } ``` ### **After** ``` { "aggregators": [], "decimals": 18, "erc20Permit": false, "image": "https://static.cx.metamask.io/api/v2/tokenIcons/assets/eip155/13371/erc20/0x0000000000000000000000000000000000000000.png", "name": "Immutable X", "occurrences": 100, "symbol": "IMX", "type": "native" } ``` https://www.loom.com/share/45f25216181146a69fc4730786c8fec9 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.  --- > [!NOTE] > **Medium Risk** > Changes how persisted asset metadata types are updated across websocket/RPC flows; incorrect classification could affect portfolio display until the next reconcile, but the logic is narrowly corrective. > > **Overview** > Updates the **Yarn patch** for `@metamask/assets-controller@8.3.2` to backport MetaMask/core#9099: asset metadata **types** are reconciled when balance/info updates land, so mislabeled entries (e.g. IMX native at the zero address stored as `erc20`) are corrected to `native`, `spl`, or `erc20`. > > The patch adds a **`getAssetType`** helper on `AssetsController` and passes it into **BackendWebsocket**, **RPC**, and **price** data sources (replacing the websocket’s `isNativeAsset` hook). During `_updateState`, it walks asset IDs from incoming `assetsInfo` / `assetsBalance` and **self-heals** `metadata[assetId].type` when it disagrees with `getAssetType`, marking those IDs as changed metadata. > > `yarn.lock` is refreshed for the new patch hash/checksum only. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 13e0626. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

Prithpal-Sooriya added 3 commits June 11, 2026 20:32

revert: TokenDataSource change - did not work

a4b8d8c

fix: add reconciliation/self-healing for asset info during update

7480667

Prithpal-Sooriya marked this pull request as ready for review June 11, 2026 22:39

Prithpal-Sooriya requested a review from a team as a code owner June 11, 2026 22:40

Prithpal-Sooriya temporarily deployed to default-branch June 11, 2026 22:40 — with GitHub Actions Inactive

cursor Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread packages/assets-controller/src/AssetsController.ts

Comment thread packages/assets-controller/src/AssetsController.ts

Prithpal-Sooriya mentioned this pull request Jun 11, 2026

fix(assets-controller): update patch to add reconciliation/self-healing metadata cp-13.35.0 MetaMask/metamask-extension#43477

Merged

7 tasks

fix(assets-controller): heal touched native asset types

3ac329f

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

cursor Bot requested a review from a team as a code owner June 11, 2026 22:46

cursoragent and others added 4 commits June 11, 2026 22:48

style(assets-controller): format touched test and controller

b92ac2e

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

test(assets-controller): align reconciliation to assetsInfo updates

23a5b2c

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

test(assets-controller): cover reconciliation with normalized asset IDs

4b06629

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

test(assets-controller): remove unnecessary asset ID assertion cast

058d875

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

Prithpal-Sooriya commented Jun 11, 2026

View reviewed changes

cursoragent and others added 2 commits June 11, 2026 23:20

fix(assets-controller): reconcile stale types on balance touches

0eef15d

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

refactor: cleanup

249ad86

salimtb approved these changes Jun 12, 2026

View reviewed changes

bergarces approved these changes Jun 12, 2026

View reviewed changes

salimtb added this pull request to the merge queue Jun 12, 2026

Merged via the queue into main with commit 80b5ef7 Jun 12, 2026
376 checks passed

salimtb deleted the fix/heal-native-token-entries branch June 12, 2026 09:44

runway-github Bot mentioned this pull request Jun 12, 2026

release(runway): cherry-pick fix(assets-controller): update patch to add reconciliation/self-healing metadata cp-13.35.0 MetaMask/metamask-extension#43500

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(assets-controller): heal native token assetsInfo entries#9099

fix(assets-controller): heal native token assetsInfo entries#9099
salimtb merged 10 commits into
mainfrom
fix/heal-native-token-entries

Prithpal-Sooriya commented Jun 11, 2026 •

edited by cursor Bot

Loading

Uh oh!

Prithpal-Sooriya commented Jun 11, 2026

Uh oh!

cursor Bot commented Jun 11, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Prithpal-Sooriya Jun 11, 2026

Uh oh!

cursor Bot Jun 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Prithpal-Sooriya commented Jun 11, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Checklist

Uh oh!

Prithpal-Sooriya commented Jun 11, 2026

Uh oh!

cursor Bot commented Jun 11, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Prithpal-Sooriya Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Thoughts

What I changed

Added coverage

Changelog

Validation run

Git

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Prithpal-Sooriya commented Jun 11, 2026 •

edited by cursor Bot

Loading

cursor Bot Jun 11, 2026 •

edited

Loading